refactor(services): clean the service drivers and their comments - #27
Merged
Merged
Conversation
…vice drivers Applies the comment-code and Clean Bash rules to the 15 services/**/*.sh driver and shared files: strip banner headers, shrink comments to the non-obvious why, convert [ ] to [[ ]], and extract each driver's probe-splice block into its own named function (splice_nest_probe, splice_laravel_probe, splice_mongodb_probe) so service_driver_apply stays a short setup sequence. No generated output changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
PR 3 of 5 (spec:
docs/superpowers/specs/2026-09-16-clean-shell-and-comments-design.md). Coversservices/**/*.sh.[ ]tests in the drivers are now[[ ]].service_driver_applybodies into same-file helperssplice_nest_probe,splice_laravel_probeandsplice_mongodb_probe, the same shape as the existingsplice_flask_probe. Driver interface functions are unchanged.assert_nest_probe_splicedand the flask splice guard, plus every byte written into generated projects.How it was verified
mise run lintexits 0.tests/service.bats48/48.test-integration69/69.test-unit195/196. The one failure isinstall.bats"start_stack logs in to ghcr only when a token is set". It fails the same way onmainand exercisescommon/install.sh, which this PR does not touch. Its stubdockernever reads stdin, so theprintffeeding--password-stdincan hit SIGPIPE.mise run checklistexits 0 for both--api flask --web nextjs --db postgres --cache redisand--api nestjs --db mongodb.mainand are byte-identical, apart from the-dirtygit-describe suffix.Checklist
mise run lintpassesmise run test-runnerpasses — see the pre-existinginstall.batsflake above