Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
flaskreachedREADME.mdanddocs/PROVENANCE.mdwhen it landed, but notdocs/tour/ordocs/runbook/. Those were not stale in the obvious way — thetour says outright to run
scaffold listrather than trust a list written intoit, and nothing anywhere claims a count of adapters. They were narrow: four
sentences describe a rule that
flaskis the first adapter to answerdifferently, and a reader following them would look in the wrong file.
docs/tour/08-adapters.mdsaid an adapter runs "a framework's owngenerator". Flask ships none, so the package manager's project init stands in
(
uv init --bare, which writes apyproject.tomland nothing else) and theoverlay supplies the application. That is a fact about the mechanism, not
about one adapter: it is what shows the overlay does not depend on a
framework generator existing.
docs/tour/01-toolchain.mdis the page about where a version is pinned,and had two answers. Flask is a third:
mise.tomlpinsuvand no python,because uv resolves its own managed interpreter and would install a
mise-pinned one only to ignore it.
docs/runbook/bump-a-toolchain-version.mdlisted where to look for aversion. Searching the
[tools]blocks for flask's python finds nothing, sothe bullet now names
.python-versionand the--pythonargument inadapters/flask/adapter.envthat setsrequires-pythonat generation.docs/runbook/add-an-adapter.mdtold an author to reach forADAPTER_POST_GENERATE"only once you've hit a real generator bug". Thatstays true for a framework generator, but where the generator writes only a
manifest the dependencies are ordinary setup, and
adapters/flaskuses thefield for exactly that. Its
mise.tomlsection and itsadapter.envsamplegain the same one-clause correction.
No prose was rewritten, no section added, and no example replaced — each edit
extends a sentence that had become narrower than the code.
How it was verified
bats tests/documentation.bats— 4/4mise run lintadapters/flask/mise.tomlpinsuvand no python,.python-versionreads3.13, andadapters/flask/adapter.env's generator carries--python 3.13.Checklist
mise run lintpassesmise run test-runnerpassesbehaviour changes, this is documentation only