Repository navigation
Import a video: File > Import Video…, drag and drop, and the agent's import command - #52
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
You can now bring a video you already have into OpenScreen and edit it.
<file name>.openscreenin the recordings folder (Name 2,Name 3… if the name is taken). It copies the video in, and never moves or changes the original. Then it writesproject.json(name, size and length from ffmpeg) and opens the editor.recording.imported). Manual zooms still work.canPlayTypecan't detect this (it even says no to QuickTime, which plays). So the importer decides from a codec list:The progress sheet shows copy or conversion progress and has Cancel. On the same APFS disk the copy is an instant clone, so no sheet appears.
The bundle is built in a hidden
.import-<id>folder and renamed into place only when it is complete, so a failed or cancelled import leaves nothing behind. Quitting mid-import asks first.import <file> [--name N]does the same import and prints the bundle path and details as JSON. Progress goes to stderr.The editor change is small and separate from the canvas code: a prop, one menu case, one drop listener, and an optional
pathonaddMusic. Main now also refuses navigation, so a stray file drop can never replace the app with the file.How was it tested?
npm run typecheckandtsc -p tsconfig.main.jsonpassnpm testpasses (694 passed, 3 skipped). The newtest/importVideo.test.tscovers: name de-duplication; sourceKind for phone, desktop and odd sizes; the transcode decision; drop routing (video → import, audio in the editor → music, other → ignored, mid-recording → ignored); the overlay label; error messages. It also runs real ffmpeg imports into a scratch folder: copy is byte-identical and the original is unchanged, de-dup, phone detection, ProRes → H.264/AAC, cancel leaves nothing, refusals leave nothing.Input.dispatchDragEventand real file paths, so the path goes throughwebUtils.getPathForFilein the preload. No renderer errors in any run.Also checked:
Screenshots
New Recording toolbar, light and dark:
Drop overlay on the New Recording screen, light and dark:
In the editor: a video, and a sound (music track):
Conversion progress with Cancel, light and dark:
Imported iPhone screen recording, and an imported screen video (no Cursor tab):
In the screenshots the sidebar shows lighter under the dark overlay. This is because the test window's vibrancy isn't captured by CDP screenshots; the real window paints it.