column split issues about doubled-up qualifier#73
Open
yzi2004 wants to merge 1 commit intotspence:mainfrom
Open
column split issues about doubled-up qualifier#73yzi2004 wants to merge 1 commit intotspence:mainfrom
yzi2004 wants to merge 1 commit intotspence:mainfrom
Conversation
Handle cases where line ends with a qualifier and not at stream end.
Owner
|
This is a really interesting find! Let me work on a test case for this so we can validate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our CSV file has a column that contains JSON-formatted data, so it includes many doubled-up qualifier. We found that sometimes the fields are not split correctly.
During debugging, we found that when reading a chunk, if the read ends just before first qualifier of a doubled-up qualifier in json data, it causes an error.
Therefore, if the last character of a line is a qualifier and there is not end of stream, it should continue reading the next chunk.
`internal class Program
{
static void Main(string[] args)
{
var settings = new CSVSettings()
{
HeaderRowIncluded = true,
BufferSize = 119,
HeadersCaseSensitive = false
};
}
sample.csv
`