fix(decoupling-caps): add deterministic row layout#99
Open
obmakesomething wants to merge 2 commits into
Open
Conversation
|
@obmakesomething is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #15
Summary
partitionType === "decoupling_caps"inSingleInnerPartitionPackingSolverso decoupling-cap partitions bypass the generic packer.decouplingCapsGap ?? chipGapedge spacing.availableRotationsand compute row width from the rotated footprint so forced-90-degree caps are spaced correctly.PackSolver2path for non-decoupling partitions.Dependency note
circuit-to-svgdependency floor so the current test suite can resolve the schematic simulation SVG export used by@tscircuit/schematic-viewerduring fresh CI installs.Tests
bun test— 22 pass, 1 skip, 0 failbun test tests/PackInnerPartitionsSolver/SingleInnerPartitionPackingSolver.test.tsbun test tests/LayoutPipelineSolver/RP2040Circuit.test.tsbun run format:checkbun run buildgit diff --checkNo UI demo video is attached because this PR changes solver layout logic, not a UI surface.