Skip to content

Fix OBJ loader cache isolation#905

Open
2bf wants to merge 1 commit into
tscircuit:mainfrom
2bf:codex/obj-loader-cache-isolation-93
Open

Fix OBJ loader cache isolation#905
2bf wants to merge 1 commit into
tscircuit:mainfrom
2bf:codex/obj-loader-cache-isolation-93

Conversation

@2bf
Copy link
Copy Markdown

@2bf 2bf commented May 20, 2026

Summary

  • normalize OBJ/WRL loader cache keys by removing cachebust_origin while preserving meaningful query params
  • keep cached loaded objects as templates and return material-isolated clones to each component instance
  • evict failed loader cache entries so transient OBJ/WRL load failures can retry

/claim #93

Verification

  • bun test tests/use-global-obj-loader.test.ts
  • bunx biome check src/hooks/use-global-obj-loader.ts tests/use-global-obj-loader.test.ts
  • bun run format:check
  • bunx tsc --noEmit
  • bun run build
  • bun run test:node-bundle
  • git diff --check

Note: a full local bun test also runs unrelated existing tests that currently fail on main around faux-board z offsets and one SVG color assertion; the new focused loader tests pass.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
3d-viewer Ready Ready Preview, Comment May 20, 2026 1:44pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant