Repository navigation
Feat/taffy layout engine - #5
Merged
Merged
Conversation
pump_workers: registry is now a strong set — an abandoned worker could be GC'd before its completion callback fired once the thread dropped its bound-method target; join() also discards on collection. Swallow BaseException so a worker raising SystemExit/KeyboardInterrupt can't kill the loop. TUI loop: clear dirtiness before build_tree() instead of after, so writes made during a view() survive to gate the next rebuild (matching flush()'s defer-to-next-tick semantics) rather than being swallowed.
Hit-testing now runs in Rust (LayoutSnapshot.hit_test) using the same scroll-clipping geometry as render_frame — a shared screen_geometry() helper is the single source of truth, retiring the Python _screen_geometry mirror that duplicated it. Focus is now explicit: Node gains a focusable flag and _is_focusable requires an enabled button, focusable=True, or an on_focus handler. on_key alone no longer implies focusable, so a root container's app-level 'q' binding stops stealing Tab focus; ScrollView opts in via focusable=True. TUI loop survives a broken view(): build_tree/layout errors are logged and the last good frame is kept, so a developer can hot-reload a fix instead of the app dying. State docstring documents mutable-value replacement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.