Skip to content

[REFACTOR] D103 upstage 정제 prompt 수정 - #164

Merged
yeremeee merged 2 commits into
developfrom
refactor/remy/163--display-text-prompt
Aug 12, 2026
Merged

[REFACTOR] D103 upstage 정제 prompt 수정 #164
yeremeee merged 2 commits into
developfrom
refactor/remy/163--display-text-prompt

Conversation

@yeremeee

@yeremeee yeremeee commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🔗 이슈 번호

📝 작업 내용

  • Upstage 추천 정제 프롬프트에 displayText 카피라이팅 규칙을 반영했습니다.

⚙️ 변경 사항

  • displayText 작성 및 conditionalText 사용 규칙 추가
  • 카피라이팅 정책에 맞게 few-shot 응답 문구 수정
  • 프롬프트 및 few-shot 버전 갱신

📸 스크린샷 (선택)

  • displayText 카피라이팅 규칙과 conditionalText 사용 규칙을 SYSTEM_PROMPT에 추가했습니다.
  • 카피라이팅 정책에 맞게 few-shot 응답 문구를 간결한 명사형과 작업 표현으로 수정했습니다.
  • 프롬프트 버전과 few-shot 버전을 갱신했습니다.
  • tests/test_refinement_prompt.py에서 두 버전 값을 함께 검증하도록 테스트를 수정했습니다.
  • 공개 API 변경이나 호환성 저하를 유발하는 breaking change는 없습니다.

@yeremeee yeremeee self-assigned this Aug 12, 2026
@yeremeee yeremeee added the refactor 기능 변경 없는 코드 구조 개선 label Aug 12, 2026
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4deb19d7-e6a4-41b7-af0f-f1ed09b8d84b

📥 Commits

Reviewing files that changed from the base of the PR and between 9b83fc0 and 8811e3d.

📒 Files selected for processing (2)
  • app/services/recommendation/prompts/refinement_prompt.py
  • tests/test_refinement_prompt.py

📝 Walkthrough

Walkthrough

Changes

D103 refinement prompt

Layer / File(s) Summary
Prompt rules and examples
app/services/recommendation/prompts/refinement_prompt.py
The prompt now defines detailed displayText, conditional-context, candidate-selection, output-limit, and JSON response rules. Few-shot examples use concise task expressions.
Version validation
tests/test_refinement_prompt.py
The test validates both PROMPT_VERSION and FEW_SHOT_VERSION.

Possibly related PRs

  • tryna-team/brain#131: Updates the same refinement prompt, tests, version identifiers, and examples.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The changes also add conditionalText usage and broader refinement rules, which are not explicitly required by issue #163. Confirm that conditionalText and broader refinement-rule changes belong to issue #163, or move them to a separate pull request.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the D103 Upstage refinement prompt change covered by the pull request.
Linked Issues check ✅ Passed The prompt adds the requested Korean displayText copywriting rules and updates related few-shot examples and versions for issue #163.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/remy/163--display-text-prompt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@yeremeee
yeremeee merged commit 645b2d8 into develop Aug 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor 기능 변경 없는 코드 구조 개선

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REFACTOR] D103 upstage 정제 prompt 수정

1 participant