Feature performance improvements #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n server case, need to discuss more
… updates, Prevented auth middleware panic by returning Poll::Pending if the mutex is busy.Increased heartbeat wait timeout to align with long-polling. Left the duplicate Casbin migration as a no-op to avoid conflicts. Added a rule to casbin for public registration of agent(testing purpose)
…and catalog, capability filtering, and payload including status, heartbeat, version, system_info, raw capabilities, and allowed commands. Unit tests cover filtering and payload cases.remove duplicates
…don't push anything to agent
Problem: Status Panel agents authenticate with 'agent' role but get 403 when accessing /api/v1/agent/commands/report endpoint. Root Cause: - Agent authentication (f_agent.rs) creates pseudo-user with role 'agent' - Earlier migration (20251222160220) added agent permissions - However, permissions may be missing on remote server Solution: - Create idempotent migration ensuring agent role has necessary permissions - Grant 'agent' role access to: * POST /api/v1/agent/commands/report (command reporting) * GET /api/v1/agent/commands/wait/:deployment_hash (command polling) - Ensure agent role inherits from group_anonymous This allows Status Panel agents to report command results without requiring per-agent Casbin rules, leveraging Vault token management for authentication. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 24149610 | Triggered | Bearer Token | 0a8b589 | src/connectors/admin_service/jwt.rs | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
… endpoin,part of meta
…of sensitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…/trydirect/stacker into feature-performance-improvements merge fix
…ayload and removing the unused import.
…> so requests are no longer serialized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.