Skip to content

fix: Create tokio runtimes before everything #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
load1n9 merged 2 commits into from
Jun 13, 2026
Merged

fix: Create tokio runtimes before everything #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84f106b
fix: Create tokio runtimes before everything
marc2332 Jun 13, 2026
bbfd8f9
update cmake
marc2332 Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions crates/cli/src/bin/satellite_run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,15 @@ fn main() -> CliResult<()> {
.map(|path| RuntimeFile::Local { path })
.collect();

let tokio_runtime = tokio::runtime::Builder::new_multi_thread()
.enable_time()
.enable_io()
.build()
.map_err(|e| {
CliError::runtime_error_simple(format!("Failed to initialize async runtime: {e}"))
})?;
let _tokio_guard = tokio_runtime.enter();

andromeda::run::run(cli.verbose, cli.no_strict, runtime_files)
.map_err(|e| CliError::runtime_error_simple(format!("{e}")))?;

Expand Down
26 changes: 13 additions & 13 deletions crates/cli/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,19 @@ fn main() {
#[allow(clippy::result_large_err)]
#[hotpath::measure]
fn run_main() -> CliResult<()> {
let rt = tokio::runtime::Builder::new_multi_thread()
.enable_time()
.enable_io()
.build()
.map_err(|e| {
error::CliError::config_error(
"Failed to initialize async runtime".to_string(),
None,
Some(Box::new(e)),
)
})?;
let _tokio_guard = rt.enter();

// Check if this is currently a single-file executable
if let Ok(Some(js)) = find_section(ANDROMEDA_JS_CODE_SECTION) {
// Try to load embedded config, fall back to defaults if not found
Expand Down Expand Up @@ -291,19 +304,6 @@ fn run_main() -> CliResult<()> {
Cli::parse()
};

let rt = tokio::runtime::Builder::new_multi_thread()
.enable_time()
.enable_io()
.build()
.map_err(|e| {
error::CliError::config_error(
"Failed to initialize async runtime".to_string(),
None,
Some(Box::new(e)),
)
})?;
let _tokio_guard = rt.enter();

let nova_result: CliResult<()> = (move || -> CliResult<()> {
match args.command {
Command::Run {
Expand Down
Loading