Repository navigation
feat(auth): persist UTM parameters in user record on signup (#75) #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TassioSales
wants to merge
1
commit into
tryabby:main
Choose a base branch
from
TassioSales:feat/save-utm-parameters-75
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use columns that can store the captured UTM values.
The capture code accepts a 200-character
utm_content, but these MySQL fields map toVARCHAR(191)in Prisma 5.19. The complete value cannot fit. (raw.githubusercontent.com)If the database rejects the value, the single update saves none of the supplied UTM fields. NextAuth catches the event error, so signup can complete without attribution. (raw.githubusercontent.com)
Use a suitable native type, such as
@db.Text, for all five fields and include the schema migration. This supports the PR objective to persist signup UTM parameters.Add a migration for the new
UserUTM columns.apps/web/prisma/schema.prismaadds fiveutm*fields toUser. No migration inapps/web/prisma/migrationsadds these columns. The container startup runsprisma migrate deploy, which applies only existing migrations. A database built from those migrations lacks the columns. Prisma selects all scalar fields when a query has no explicitselect, so anyUserquery without one can fail with a missing-column error after this change is deployed.Generate the migration with the schema change and commit it: