chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3#808
Open
red-hat-konflux[bot] wants to merge 1 commit into
Open
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the indirect Go module dependency gomodules.xyz/jsonpatch/v2 in go.mod to a newer major version line, aligning with Renovate’s suggested jsonpatch v3 series while adjusting the v2 requirement entry. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The PR title/description indicate an upgrade to gomodules.xyz/jsonpatch v3, but go.mod is downgrading from v2.5.0 to v2.4.0 on the v2 module path—please align the dependency version and module path with the intended v3 upgrade.
- Since jsonpatch introduces a new major version, double‑check that all import paths are updated to the v3 module path and that any required code changes for the breaking release notes are included in this PR.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The PR title/description indicate an upgrade to gomodules.xyz/jsonpatch v3, but go.mod is downgrading from v2.5.0 to v2.4.0 on the v2 module path—please align the dependency version and module path with the intended v3 upgrade.
- Since jsonpatch introduces a new major version, double‑check that all import paths are updated to the v3 module path and that any required code changes for the breaking release notes are included in this PR.
## Individual Comments
### Comment 1
<location path="go.mod" line_range="127" />
<code_context>
golang.org/x/text v0.36.0 // indirect
golang.org/x/time v0.15.0 // indirect
- gomodules.xyz/jsonpatch/v2 v2.5.0 // indirect
+ gomodules.xyz/jsonpatch/v2 v2.4.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20260427160629-7cedc36a6bc4 // indirect
google.golang.org/grpc v1.81.0 // indirect
</code_context>
<issue_to_address>
**🚨 issue (security):** Downgrading jsonpatch may reintroduce fixed bugs or security issues; is this version change intentional and validated?
If this is to work around a regression in v2.5.0, please confirm that we don’t rely on any fixes introduced after v2.4.0 (especially security or bug fixes) and that the upstream changelog has been reviewed to validate that v2.4.0 still meets our requirements.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
2653a47 to
847c342
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v2.5.0→v3.0.1Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
gomodules/jsonpatch (gomodules.xyz/jsonpatch/v2)
v3.0.1Compare Source
This release uses our forked gomodules/orderedmap library. Our forked version has 2 major changes:
*OrderedMapinstead ofOrderedMapinside nested orderedmaps.v3.0.0Compare Source
This release uses iancoleman/orderedmap to generate predictable patch. This is very useful if the generated patch is checked into a VCS like git.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.