fix(deps): update module sigs.k8s.io/controller-runtime to v0.24.1#802
Open
red-hat-konflux[bot] wants to merge 1 commit into
Open
Conversation
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Go module dependency sigs.k8s.io/controller-runtime from v0.23.3 to v0.24.1 in go.mod, pulling in the associated upstream controller-runtime and Kubernetes 1.36 dependency changes and fixes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Controller-runtime v0.24.x updates its k8s.io/* dependencies to v0.36, so consider bumping your k8s.io modules (apiextensions-apiserver, apimachinery, client-go, etc.) to the corresponding v0.36.x versions to avoid version skew and potential incompatibilities.
- Given the breaking changes in controller-runtime v0.24.0 (e.g., removal of some deprecated builders/webhook path helpers), scan for usages of deprecated APIs mentioned in the release notes and verify they still compile and behave as expected after the upgrade.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Controller-runtime v0.24.x updates its k8s.io/* dependencies to v0.36, so consider bumping your k8s.io modules (apiextensions-apiserver, apimachinery, client-go, etc.) to the corresponding v0.36.x versions to avoid version skew and potential incompatibilities.
- Given the breaking changes in controller-runtime v0.24.0 (e.g., removal of some deprecated builders/webhook path helpers), scan for usages of deprecated APIs mentioned in the release notes and verify they still compile and behave as expected after the upgrade.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v0.23.3→v0.24.1Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)
v0.24.1Compare Source
What's Changed
Full Changelog: kubernetes-sigs/controller-runtime@v0.24.0...v0.24.1
v0.24.0Compare Source
🐛 Bug Fixes
🌱 Others
StartLoggingfor event debug logs (#3451)🌱 CI & linters
tools/setup-envtestsubmodule (#3476)📖 Additionally, there has been 1 contribution to our documentation. (#3477)
Dependencies
Added
Changed
8a7402a→944ab1f078029d→bd525daa0af3ef→8636f87200df99→8636f87f2248ac589584f→43fb72cbc988d5→b8788abRemoved
9bdfabeThanks to all our contributors! 😊
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.