fix(deps): update kubernetes packages to v0.36.1#801
Open
red-hat-konflux[bot] wants to merge 1 commit into
Open
fix(deps): update kubernetes packages to v0.36.1#801red-hat-konflux[bot] wants to merge 1 commit into
red-hat-konflux[bot] wants to merge 1 commit into
Conversation
Contributor
Author
ℹ️ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Go toolchain version and aligns all Kubernetes-related dependencies from v0.35.1 to v0.36.1 (plus associated indirect modules), removing now-unneeded indirect deps, with no application code changes. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 2 issues, and left some high level feedback:
- Since the Go version is bumped to 1.26.0 in go.mod, ensure any build/CI tooling (Docker images, GitHub Actions, Makefiles, etc.) is also updated to use Go 1.26 to avoid version mismatches.
- You updated the Kubernetes libraries to v0.36.1 but controller-runtime is still on v0.23.3; consider aligning controller-runtime to a version known to target the same Kubernetes minor to reduce the risk of subtle API incompatibilities.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the Go version is bumped to 1.26.0 in go.mod, ensure any build/CI tooling (Docker images, GitHub Actions, Makefiles, etc.) is also updated to use Go 1.26 to avoid version mismatches.
- You updated the Kubernetes libraries to v0.36.1 but controller-runtime is still on v0.23.3; consider aligning controller-runtime to a version known to target the same Kubernetes minor to reduce the risk of subtle API incompatibilities.
## Individual Comments
### Comment 1
<location path="go.mod" line_range="3" />
<code_context>
module github.com/trustification/trusted-profile-analyzer-operator
-go 1.25.0
+go 1.26.0
require (
</code_context>
<issue_to_address>
**issue (bug_risk):** Using a future Go version may cause build issues with current tooling.
The `go 1.26.0` directive requires a Go 1.26 toolchain, which is not yet released and can break builds/CI for consumers. Unless you explicitly depend on unreleased features, please use the latest stable version you actually need (e.g. `go 1.22`) and omit the patch (`go 1.22` instead of `go 1.22.0`) for flexibility.
</issue_to_address>
### Comment 2
<location path="go.mod" line_range="13" />
<code_context>
- k8s.io/apiextensions-apiserver v0.35.1
- k8s.io/apimachinery v0.35.1
- k8s.io/client-go v0.35.1
+ k8s.io/api v0.36.1
+ k8s.io/apiextensions-apiserver v0.36.1
+ k8s.io/apimachinery v0.36.1
+ k8s.io/client-go v0.36.1
sigs.k8s.io/controller-runtime v0.23.3
)
</code_context>
<issue_to_address>
**suggestion (bug_risk):** Kubernetes library versions and controller-runtime may be out of sync.
Core k8s libs are now at `v0.36.1` while `controller-runtime` remains at `v0.23.3`. Please check the controller-runtime compatibility matrix for k8s `v0.36.x` and either upgrade controller-runtime to the matching version or document that this specific combination is supported.
```suggestion
// NOTE: controller-runtime v0.23.3 is verified to be compatible with k8s.io/* v0.36.x.
// See: https://github.com/kubernetes-sigs/controller-runtime#compatibility-matrix
sigs.k8s.io/controller-runtime v0.23.3
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -1,15 +1,15 @@ | |||
| module github.com/trustification/trusted-profile-analyzer-operator | |||
|
|
|||
| go 1.25.0 | |||
There was a problem hiding this comment.
issue (bug_risk): Using a future Go version may cause build issues with current tooling.
The go 1.26.0 directive requires a Go 1.26 toolchain, which is not yet released and can break builds/CI for consumers. Unless you explicitly depend on unreleased features, please use the latest stable version you actually need (e.g. go 1.22) and omit the patch (go 1.22 instead of go 1.22.0) for flexibility.
| k8s.io/apiextensions-apiserver v0.36.1 | ||
| k8s.io/apimachinery v0.36.1 | ||
| k8s.io/client-go v0.36.1 | ||
| sigs.k8s.io/controller-runtime v0.23.3 |
There was a problem hiding this comment.
suggestion (bug_risk): Kubernetes library versions and controller-runtime may be out of sync.
Core k8s libs are now at v0.36.1 while controller-runtime remains at v0.23.3. Please check the controller-runtime compatibility matrix for k8s v0.36.x and either upgrade controller-runtime to the matching version or document that this specific combination is supported.
Suggested change
| sigs.k8s.io/controller-runtime v0.23.3 | |
| // NOTE: controller-runtime v0.23.3 is verified to be compatible with k8s.io/* v0.36.x. | |
| // See: https://github.com/kubernetes-sigs/controller-runtime#compatibility-matrix | |
| sigs.k8s.io/controller-runtime v0.23.3 |
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/release/2.y.z/kubernetes-go
branch
4 times, most recently
from
f06693b to
790bf9b
Compare
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/release/2.y.z/kubernetes-go
branch
from
790bf9b to
5cd9f61
Compare
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
red-hat-konflux
Bot
force-pushed
the
konflux/mintmaker/release/2.y.z/kubernetes-go
branch
from
5cd9f61 to
91b1bd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v0.35.1→v0.36.1v0.35.1→v0.36.1v0.35.1→v0.36.1v0.35.1→v0.36.1v0.35.1→v0.36.1v0.35.1→v0.36.1v0.35.1→v0.36.1v0.35.1→v0.36.1Warning
Some dependencies could not be looked up. Check the warning logs for more information.
Release Notes
kubernetes/api (k8s.io/api)
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.5Compare Source
v0.35.4Compare Source
v0.35.3Compare Source
v0.35.2Compare Source
kubernetes/apiextensions-apiserver (k8s.io/apiextensions-apiserver)
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.5Compare Source
v0.35.4Compare Source
v0.35.3Compare Source
v0.35.2Compare Source
kubernetes/apimachinery (k8s.io/apimachinery)
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.5Compare Source
v0.35.4Compare Source
v0.35.3Compare Source
v0.35.2Compare Source
kubernetes/apiserver (k8s.io/apiserver)
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.5Compare Source
v0.35.4Compare Source
v0.35.3Compare Source
v0.35.2Compare Source
kubernetes/cli-runtime (k8s.io/cli-runtime)
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.5Compare Source
v0.35.4Compare Source
v0.35.3Compare Source
v0.35.2Compare Source
kubernetes/client-go (k8s.io/client-go)
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.5Compare Source
v0.35.4Compare Source
v0.35.3Compare Source
v0.35.2Compare Source
kubernetes/component-base (k8s.io/component-base)
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.5Compare Source
v0.35.4Compare Source
v0.35.3Compare Source
v0.35.2Compare Source
kubernetes/kubectl (k8s.io/kubectl)
v0.36.1Compare Source
v0.36.0Compare Source
v0.35.5Compare Source
v0.35.4Compare Source
v0.35.3Compare Source
v0.35.2Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.