feat: implement milestone time-locks - #54
Merged
Merged
Conversation
Add time-lock checks to ensure milestones cannot be claimed prematurely. - Add release_time field to Milestone struct (u32 for ledger sequence) - Add MilestoneTimeLocked error variant for premature release attempts - Implement time-lock validation in release_milestone_tranche - Add comprehensive unit tests for time-lock functionality - Update all existing tests to include release_time: 0 for backward compatibility - Event emission for indexing remains intact Acceptance Criteria: - Feature accurately implements time-lock checks - No Rust errors introduced - All 62 tests pass - WASM build successful - Code formatted with cargo fmt - Clippy checks pass
meshackyaro
approved these changes
Jul 30, 2026
meshackyaro
left a comment
meshackyaro
left a comment
Contributor
There was a problem hiding this comment.
This is good, with all the acceptance criteria met and this is ready for merge. Well done
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add time-lock checks to ensure milestones cannot be claimed prematurely.
Acceptance Criteria:
Closes #2