Fix SIGHUP: reload config instead of shutting down#323
Open
thegushi wants to merge 1 commit into
Open
Conversation
SIGHUP was treated identically to SIGTERM, causing the filter to exit. Unix convention is that SIGHUP triggers a configuration reload in long-running daemons. The reload path already exists (previously only reachable via SIGUSR1); SIGHUP is now folded into it. SIGUSR1 continues to work as before. SIGTERM and SIGINT remain the shutdown signals. Fixes: trusteddomainproject#322
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #322.
SIGHUPwas grouped withSIGTERMandSIGINTin the signal handler,causing the filter to shut down — contrary to Unix convention, where
SIGHUPis the standard signal for configuration reload or log reopen.The reload path already existed (previously reachable only via
SIGUSR1);this change folds
SIGHUPinto the same condition.SIGTERMandSIGINTremain the shutdown signals.SIGUSR1continuesto work as before.
Changes:
opendmarc/opendmarc.c: removeSIGHUPfrom the shutdown condition;add it to the reload condition alongside
SIGUSR1opendmarc/opendmarc.8.in: document that bothSIGHUPandSIGUSR1trigger a configuration reload