Detect perl path at configure time instead of hardcoding /usr/bin/perl#318
Open
thegushi wants to merge 1 commit into
Open
Detect perl path at configure time instead of hardcoding /usr/bin/perl#318thegushi wants to merge 1 commit into
thegushi wants to merge 1 commit into
Conversation
Add AC_PATH_PROG([PERL], [perl], [/usr/bin/perl]) to configure.ac and replace the hardcoded #!/usr/bin/perl shebang in all four report scripts with #!@Perl@ so that systems where perl lives elsewhere (e.g. /usr/local/bin/perl on FreeBSD) get the correct shebang.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The shebang in all four report scripts (
opendmarc-reports,opendmarc-import,opendmarc-expire,opendmarc-params) was hardcoded as#!/usr/bin/perl. On systems where Perl is not at/usr/bin/perl(notably FreeBSD, where it is installed at/usr/local/bin/perlfrom ports), the installed scripts fail with "not found".AC_PATH_PROG([PERL], [perl], [/usr/bin/perl])toconfigure.acsoconfiguredetects the correct Perl path, falling back to/usr/bin/perlif not found#!/usr/bin/perlwith#!@PERL@in all four.infiles so the correct path is substituted at build timeTest plan
autoreconf && ./configure— confirmchecking for perl... /usr/local/bin/perlin configure output#!/usr/local/bin/perlshebang/usr/bin/perl: confirm shebang is unchangedPERL=/custom/path/perlto configure and confirm it overrides detection