Fix arc=pass never appearing in aggregate reports (issue #282)#313
Open
thegushi wants to merge 1 commit into
Open
Fix arc=pass never appearing in aggregate reports (issue #282)#313thegushi wants to merge 1 commit into
thegushi wants to merge 1 commit into
Conversation
…nproject#282) ARES_RESULT_PASS is 0, but the arc switch in opendmarc-reports used case 1 (ARES_RESULT_UNUSED), so ARC pass was never matched and all messages were reported as arc=fail regardless of actual ARC evaluation. The arc_policy switch was correctly fixed to case 0 in commit 199b506 but the arc switch was missed at the same time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #282.
ARES_RESULT_PASSis 0, but thearcswitch inopendmarc-reportsusedcase 1(ARES_RESULT_UNUSED), so ARC pass was never matched and all messages were reported asarc=failin aggregate reports regardless of actual ARC evaluation.The
arc_policyswitch was correctly fixed tocase 0in commit 199b506 but thearcswitch was missed at the same time.This started as a suspected doc issue but git blame showed it was a real bug introduced with the original ValiMail ARC contribution and only half-fixed in the follow-up commit.