Fix arcdomain memory leak in mlfi_eom (issue #182)#310
Open
thegushi wants to merge 1 commit into
Open
Conversation
arcdomain was strdup'd on each loop iteration but never freed, leaking on both the continue path and at loop exit. Free it after the hash lookup, before the eptr NULL check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #182.
arcdomainwasstrdup'd on each iteration of the ARC chain loop butnever freed — it leaked on the
continuepath when the hash lookupmissed, and again at loop exit when it hit. Free it after the
pthread_rwlock_unlockcall, before theeptrNULL check, so it'sreleased on every iteration regardless of outcome.
Credit to @KIC-8462852 for the original patch.