Re-design/re-implement parser for AAR header using AR header parser#305
Open
futatuki wants to merge 6 commits into
Open
Re-design/re-implement parser for AAR header using AR header parser#305futatuki wants to merge 6 commits into
futatuki wants to merge 6 commits into
Conversation
…uthres * oepndmarc/opendmarc-ar.h (ARES_MAXTOKENS): increase value to accept AAR header * opendmarc/opendmarc-ar.c, openarc/opendmarc-ar.h (authres_parse): Renamed from ares_parse, with modification to parse AAR header (authres_parse): Turn into inline function using authres_parse()
…unction *opendmarc/opendmarc-ar.c (main): as above
and use it for the buffer size to parse ARCARES/ARES headers.
With this commit, by reusing data structures / functions for the parser of AR headers, We can parse ARC-AR headers more pricisely now.
- ignore unknown method (to reduce holding results) - ignore results after result fields are fully filled, but continue parsing for syntax check
Author
|
I don't have living example message which has AAR header with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation of the parser for ARC-Authentication-Result (AAR) header is specialized to the intention to aquire IP address from ARC result and has some unresolved issues, including the issue that it would almost fail to aquire it because of the change of specification of ARC.
So I've re-implement it by using, commonize tokenizer/parser for Authentication-Result header, and then adopt it to opendmarc milter for current usage.