opendkim: insert A-R and DKIM-Signature headers at index 0 (issue #24)#346
Merged
thegushi merged 1 commit intoMay 25, 2026
Merged
Conversation
…steddomainproject#24) RFC 8601 sections 4 and 7.1 require Authentication-Results to be inserted before the MTA's Received header. SpamAssassin and other verifiers also rely on this ordering to determine which AR headers can be trusted. Change all dkimf_insheader() calls from index 1 to index 0 so that Authentication-Results, DKIM-Signature, VBR-Info, and X-OpenDKIM headers are prepended before existing headers rather than inserted after the first one. Patch originally by @glts (PR trusteddomainproject#126), credit also to @fanto666. Fixes trusteddomainproject#24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Authentication-Resultsto be inserted before the MTA'sReceivedheaderReceivedheaders to determine trustdkimf_insheader()calls used index1(insert after the first header); changed to0(prepend before all headers) across all 7 call sites:Authentication-Results,DKIM-Signature,VBR-Info, andX-OpenDKIMCredit to @glts (original PR #126) and @fanto666 for the patch.
Fixes #24