opendkim: don't add A-R header in sign-only mode when sender unresolvable (issue #130)#345
Merged
thegushi merged 1 commit intoMay 25, 2026
Conversation
…able (issue trusteddomainproject#130) When the message sender can't be determined or parsed, opendkim was unconditionally setting mctx_addheader/mctx_headeronly and inserting an Authentication-Results header with dkim=permerror. In sign-only mode (Mode s) this is wrong - no A-R headers should be added. Guard both sites in mlfi_eoh() with a DKIMF_MODE_VERIFIER check so the BADFORMAT A-R header is only inserted when verification is active. Fixes trusteddomainproject#130
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mlfi_eoh(), when the message sender can't be determined or parsed, opendkim was unconditionally settingmctx_addheader = TRUEand inserting anAuthentication-Results: ... dkim=permerror (bad message/signature format)headerMode s), no A-R headers should ever be added - that's verification output(conf->conf_mode & DKIMF_MODE_VERIFIER) != 0so the BADFORMAT A-R header is only inserted when verification is activeFixes #130