opendkim: fix always-false NULL check on mctx_domain array (issue #88)#343
Merged
thegushi merged 1 commit intoMay 25, 2026
Conversation
…steddomainproject#88) mctx_domain is a fixed-size array, not a pointer; comparing it to NULL is always false. The intent is to detect an unset message domain, so use mctx_domain[0] == '\0' consistent with other checks in the file. Fixes trusteddomainproject#88
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mctx_domainis declared asunsigned char mctx_domain[DKIM_MAXHOSTNAMELEN + 1]- a fixed-size array, not a pointerdfc->mctx_domain == NULLis always false, meaning the error-log-and-return path at that site was dead codedfc->mctx_domain[0] == '\0'to correctly detect an unset message domain, consistent with the same check at line 11952Fixes #88