configure.ac: update main() signatures to conform to the standard#171
Open
orlitzky wants to merge 2 commits into
Open
configure.ac: update main() signatures to conform to the standard#171orlitzky wants to merge 2 commits into
orlitzky wants to merge 2 commits into
Conversation
There are some tests in configure.ac that contain,
int main() { ... }
That's not the correct signature for main() according to the C
standard, and newer compilers are going to reject it. More information
about this can be found at,
https://wiki.gentoo.org/wiki/Modern_C_porting
In this case, the fix is simply to write
int main(int argc, char** argv) { ... }
instead.
The vbr_strlcpy() function declares that its arguments should live in
registers:
vbr_strlcpy(dst, src, size)
register char *dst;
register const char *src;
ssize_t size;
{
...
This makes GCC unhappy when -Werror=strict-prototypes is used:
vbr.c:167:1: error: function declaration isn't a prototype
[-Werror=strict-prototypes]
167 | vbr_strlcpy(dst, src, size)
The "register" keyword is largely obsolete on modern systems anyway,
since the compiler is better at determining how to move memory around
than the programmer is. So to appease GCC and simplify the code a bit,
the signature has been changed to,
vbr_strlcpy(char *dst, const char *src, ssize_t size) { ... }
changes. Lines starting # with '#' will be ignored, and an empty
message aborts the commit. # # On branch configure.ac-c-standard #
Your branch is up to date with 'origin/configure.ac-c-standard'. # #
Changes to be committed: # modified: libvbr/vbr.c # # Changes not
staged for commit: # modified: configure # # Untracked files: #
0000-cover-letter.patch #
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Mar 4, 2024
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Mar 11, 2024
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Mar 11, 2024
PR trusteddomainproject#171, trusteddomainproject#192, and trusteddomainproject#203 contains changes in configure.ac, however they were not always reflect their changes into configure. So rebuild it here.
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Apr 26, 2024
…c-c-standard configure.ac: update main() signatures to conform to the standard. libvbr/vbr.c: fix function signature for vbr_strlcpy into modern C style.
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Apr 26, 2024
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Apr 26, 2024
PR trusteddomainproject#171, trusteddomainproject#192, and trusteddomainproject#204 contains changes in configure.ac, however they were not always reflect their changes into configure. So rebuild it here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some tests in configure.ac that contain,
int main() { ... }
That's not the correct signature for main() according to the C standard, and newer compilers are going to reject it. More information about this can be found at,
https://wiki.gentoo.org/wiki/Modern_C_porting
In this case, the fix is simply to write
int main(int argc, char** argv) { ... }
instead.