use transparent strlcpy/strlcat fallback#151
Open
guijan wants to merge 1 commit into
Open
Conversation
Using _libbsd-overlay_ through pkg-config allows accessing `strlcpy`/`strlcat` by including `<string.h>`, just like on BSD. This simplifies compatibility code massively.
Author
|
Poking @mskucherawy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using libbsd-overlay through pkg-config allows accessing
strlcpy/strlcatby including<string.h>and programming as if we're on BSD. This simplifies compatibility code massively.My interest here is making OpenDKIM work with my libobsd library which I'm trying to get into OpenWRT at openwrt/openwrt#9714. OpenDKIM is one of the programs my library needs to work with for that.
My library can act as an alternative to libbsd, and I'm trying to get others to use libbsd's libbsd-overlay mode over the normal libbsd mode because I think it leads to smaller, simpler, and cleaner code as evidenced by this PR.
I've build tested this on Alpine Linux and OpenBSD.