Repository navigation
Conversation
Passes artifactory_oidc_provider_name so this repository authenticates to JFrog as a least-privilege account scoped to the artifacts it publishes, rather than the shared org-wide identity that holds MANAGE across an entire artifact tier. Requires truefoundry/github-workflows-public#31 (adds the input). No-op until that merges. Co-Authored-By: Claude Code <noreply@anthropic.com>
DeeAjayi
requested review from
chiragjn,
debajyoti-truefoundry,
heerambavi1998 and
thesujai
as code owners
October 20, 2026 12:50
|
artifactory_username and artifactory_password are declared on the shared workflows but ignored -- JFrog auth there is OIDC-only. Passing them implies a credential path that no longer exists. Removing them from callers is a prerequisite for dropping the declarations from the shared workflows, which cannot happen while callers still pass them: reusable workflows validate secrets strictly, so an undeclared secret fails the run. Co-Authored-By: Claude Code <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TrueForge gets its own dedicated JFrog integrations rather than sharing the org-wide tier accounts. The hardened image goes to a different Artifactory repo than the public one, so it gets a separate integration.
push-sandbox-image.ymlbuildTRUEFOUNDRY_ARTIFACTORY_PUBLIC_REPOSITORYgithub-jfrog-trueforgerelease.ymlbuild-image-publicTRUEFOUNDRY_ARTIFACTORY_PUBLIC_REPOSITORYgithub-jfrog-trueforgerelease.ymlbuild-image-privateTRUEFOUNDRY_ARTIFACTORY_PRIVATE_REPOSITORYgithub-jfrog-trueforge-privateNot changed
release-chart.ymlpublishes the Helm chart with static Artifactory credentials rather than OIDC. Moving that is a separate migration.No other inputs, secrets, or steps are touched — including
build-image-private's ECR pull-through config.Ready to merge
The shared-workflow dependency has landed — truefoundry/workflows#49 and github-workflows-public#31 are both merged, so
artifactory_oidc_provider_nameexists onmain. (An earlier version of this description said to wait; that is no longer accurate.)Access is additionally gated by a per-repository allowlist in ubermold-truefoundry#2314 (
jfrog/oidc.tf), which is not yet merged. Until it is, this repo is not on the allowlist and the push will fail authorization.So: merge #2314 first, then this. Merging this alone breaks publishing for this repo.
After merging
Confirm the next build actually pushed. A wrong integration fails at push time, not at plan time.
🤖 Generated with Claude Code
Note
Medium Risk
Release and sandbox image publishing now depend on OIDC provider configuration and repo allowlisting; misconfiguration fails at push time and blocks publishing until infra is aligned.
Overview
Docker image publish jobs in
push-sandbox-image.ymlandrelease.ymlnow authenticate to JFrog Artifactory via GitHub OIDC instead of long-lived username/password secrets.Each reusable
build.ymlcall passesartifactory_oidc_provider_name:github-jfrog-trueforgefor the sandbox image and public server image (public Artifactory repo), andgithub-jfrog-trueforge-privatefor the hardened server image (private repo). The correspondingartifactory_username/artifactory_passwordsecrets blocks are removed from those jobs;build-image-privatestill passes ECR pull and PostHog build secrets unchanged.Helm chart publishing (
release-chart.yml) is not part of this change and still uses static Artifactory credentials.Reviewed by Cursor Bugbot for commit 4d69766. Bugbot is set up for automated code reviews on this repo. Configure here.
Also in this PR: dropping the deprecated secrets
artifactory_username/artifactory_passwordare declared on the shared workflows but ignored — auth there is OIDC-only. This stops passing them.Safe on its own: the shared workflows still declare them as optional, so removing them from the caller changes nothing at runtime. It is a prerequisite for removing the declarations later, which cannot happen while any caller still passes them.
Static-credential steps in this repo (direct
docker login,helm push) are untouched — those use real credentials and are a separate migration.