Repository navigation
Conversation
thesujai
requested review from
chiragjn,
debajyoti-truefoundry and
heerambavi1998
as code owners
October 19, 2026 14:44
🦋 Changeset detectedLatest commit: e77649f The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e77649f. Configure here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Closes #
Changes
How was this tested?
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,python/trueforge_sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Medium Risk
Automatically cancels turns based on staleness, which can end agent work if thresholds are wrong or activity is not recorded; Helm default termination grace jumps from ~35s to 300s unless overridden.
Overview
Adds an abandoned-turn closer so long-idle
runningturns do not stay stuck forever. The controller runs a new periodic loop that calls internal HTTP APIs to list stale running turns (last activity older thanABANDONED_TURN_STALE_MS, default 15m) and close them in batches (ABANDONED_TURN_CLOSE_BATCH/ABANDONED_TURN_CLOSER_INTERVAL_MS), emittingturn.donewithCancellationReason.Abandoned.Session stores gain
listStaleRunningTurns(Postgres/SQLite/in-memory) keyed off last event time orturn.created_at. Service-key routes live at/api/internal/turns/abandonedand/close-abandoned, wired throughcancelSessionTurnlike other cancellations. OpenAPI and TS/Python SDKs are regenerated forclient.internal.turns.Helm now sets pod
terminationGracePeriodSecondsfromserver.terminationGracePeriodSeconds(default 300) instead ofgracefulTimeoutSeconds + 5, with docs/env examples for the new knobs.Reviewed by Cursor Bugbot for commit 433eea4. Bugbot is set up for automated code reviews on this repo. Configure here.