Skip to content

fix: hide session share URL when access is Only you (AGE-2534) - #1098

Open
govindavashishtha wants to merge 1 commit into
mainfrom
govinda/age-2534-hide-session-share-link-when-access-is-only-you
Open

govindavashishtha wants to merge 1 commit into
mainfrom
govinda/age-2534-hide-session-share-link-when-access-is-only-you

Conversation

@govindavashishtha

@govindavashishtha govindavashishtha commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Fixes AGE-2534: the share popover no longer shows a copyable Share URL while access is Only you, so people cannot send links others cannot open.
  • The Share button and permission selector stay; switching to tenant access reveals the URL and Copy control immediately.
  • Covers chat header and sessions detail (same ShareSessionDialog).

Test plan

  • pnpm --filter @truefoundry/trueforge-ui exec vitest run test/atoms/ShareSessionDialog.test.tsx test/atoms/ShareChatButton.test.tsx test/atoms/SessionsPage.test.tsx
  • Open Share on a private session — permissions only, no Share URL / Copy
  • Switch to Everyone within tenant — Share URL and Copy appear
  • Switch back to Only you — Share URL disappears again

Made with Cursor


Note

Low Risk
UI-only conditional rendering in the share popover with no API or auth changes; behavior is covered by updated atom tests.

Reviewed by Cursor Bugbot for commit 7d5b30f. Bugbot is set up for automated code reviews on this repo. Configure here.

Stop offering a copyable share link for private sessions so people do not send inaccessible URLs (AGE-2534).

Co-authored-by: Cursor <cursoragent@cursor.com>
@changeset-bot

changeset-bot Bot commented Oct 19, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7d5b30f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@truefoundry/trueforge-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants