Repository navigation
fix: reject folder attachments that silently block chat send - #1097
Merged
govindavashishtha merged 2 commits intoOct 19, 2026
Conversation
Folders were accepted as pending attachments then failed on send with NotFoundError and no UI feedback. Reject them at add time and toast on drop. Co-authored-by: Cursor <cursoragent@cursor.com>
govindavashishtha
requested review from
kumarsks619,
qaifi-tf,
sajal-truefoundry,
sayan-truefoundry and
vinit-truefoundry
as code owners
October 19, 2026 10:53
🦋 Changeset detectedLatest commit: 80beecc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
vinit-truefoundry
approved these changes
Oct 19, 2026
govindavashishtha
enabled auto-merge (squash)
October 19, 2026 12:07
…-block-message-submission-in
govindavashishtha
deleted the
govinda/age-2547-folder-attachments-silently-block-message-submission-in
branch
October 19, 2026 12:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendfailed withNotFoundErrorand no UI feedback.trueForgeAttachmentAdapter.addnow probes the file blob and rejects directories before they enter the composer.webkitGetAsEntry, skips attachment analytics for folder-only drops, and toasts that folders cannot be attached.Test plan
pnpm test:assistant-ui-runtimeandpnpm test:trueforge-ui(or the focused attachment/composer tests)Made with Cursor
Note
Low Risk
Localized to chat attachment add/drop handling with explicit user errors; no auth, data, or API contract changes.
Reviewed by Cursor Bugbot for commit 80beecc. Bugbot is set up for automated code reviews on this repo. Configure here.