Repository navigation
[Turn Steal 5/N]: feat: rebuild, offload, and steal a paused turn #1070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
00516af
feat: rebuild a paused turn from its own snapshot
chiragjn cd79652
feat: offload a paused turn and steal it when the owner is gone
chiragjn c3f9816
Regenerate OpenAPI document and SDKs
trueforge-dev-bot[bot] 6b589c7
fix: emit turn.done when the next turn supersedes a live run
chiragjn 1839012
Merge branch 'ha/emit-pause' of https://github.com/truefoundry/truefo…
chiragjn 9c564d7
fix: drop the peer inline-skill overlay
chiragjn 5a4ce8d
feat: keep a paused turn in memory for five minutes
chiragjn a8183b2
Merge branch 'ha/emit-pause' of https://github.com/truefoundry/truefo…
chiragjn 64e7d3d
fix: send the caller request context when peering a paused turn
chiragjn 39160bd
fix: offload paused turns that the keepalive timer could not see
chiragjn 66149c4
fix: require the peer router and session store on turn start
chiragjn 21ac55a
Refactor resolvers
chiragjn 6c35586
Minor rename in inMemory store
chiragjn 9e95d75
refactor: execute turns from stored status instead of a resume flag
chiragjn 9b4ca95
Address some review comments
chiragjn e4e6ede
Don't cancel during create turn, just freeze
chiragjn 8eaef04
Do not use send to queue up pending events
chiragjn 86224d9
Address more review comments
chiragjn ac7ccfa
Address more review comments
chiragjn c6389ef
Run the execution timer only during running phase
chiragjn 8863eb5
Address race conditions pointed by cursor
chiragjn 902799a
Address more race condition with heartbeat gone
chiragjn 6899475
Merge branch 'ha/emit-pause' of https://github.com/truefoundry/truefo…
chiragjn 6cda749
Add logs
chiragjn b876cc3
Fix approval policy across turns
chiragjn 0b4bb91
Simplify logging and reduce diff in api/sessions.ts
chiragjn 485d552
refactor activeTurns.ts for rebuilding and live phase
chiragjn b74dbb6
Add comments to activeTurn.ts
chiragjn 853dcd5
Simplify code for stealing decision
chiragjn 867ea89
Simplify code in turn.ts
chiragjn f9bf11f
Regenerate OpenAPI document and SDKs
trueforge-dev-bot[bot] 001d09f
update error messages
chiragjn cb4649c
Merge branch 'cj-turn-resume' of https://github.com/truefoundry/truef…
chiragjn dcfd21f
Log each turn-send decision and reject a running turn the executor di…
chiragjn ad55dc0
Regenerate OpenAPI document and SDKs
trueforge-dev-bot[bot] fcaa006
Fix tests
chiragjn 4629532
Merge branch 'cj-turn-resume' of https://github.com/truefoundry/truef…
chiragjn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| '@truefoundry/trueforge': patch | ||
| '@truefoundry/trueforge-core': patch | ||
| --- | ||
|
|
||
| Rebuild a paused turn on its owner, offload it after a keepalive, and steal it only when the owner's heartbeat is gone. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changeset added on stacked PR
Low Severity
This stacked
5/Nchange adds a.changesetfile. Changesets belong only on a merge tomain; stacked or non-main bases should omit them so version bumps stay on the release path.Triggered by learned rule: Prereleases use rc tags only
Reviewed by Cursor Bugbot for commit c3f9816. Configure here.