Conversation
…w limit The switcher still fell back to icons on a busy Space even under the 0.2.3 "Previews up to" setting, because TileSizing.fit independently forced icon mode whenever windowCount tiles could not fit in three rows without scrolling -- a check unrelated to the configured limit, and one the switcher grid (already inside a ScrollView) never needed. 28 windows, the exact case 0.2.3's commit message named, still hit this: at the overlay's capped 1400pt width, three rows of 120pt tiles fit at most 27. TileSizing.fit now returns the floor width instead of giving up, and the grid scrolls for the rest. TileModePolicy.resolve, driven by switcherPreviewLimit, is the only thing left deciding previews vs. icons. Claude-Session: https://claude.ai/code/session_01Ez14nyXC16CaNvU6z7vN6W Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TileSizing.fitindependently forced icon mode whenever a window count needed more than three rows without scrolling — a check unrelated to the configured limit, and unnecessary since the switcher grid is already inside aScrollView.TileSizing.fitnow returns the floor width instead of giving up;TileModePolicy.resolve(driven byswitcherPreviewLimit) is the only thing left deciding previews vs. icons.Test plan
swift test— 245/245 pass, including a new regression test reproducing the 28-window/1400pt case (red before the fix, green after)bash scripts/check.sh— all checks pass🤖 Generated with Claude Code
https://claude.ai/code/session_01Ez14nyXC16CaNvU6z7vN6W