fix(configure): skip venv creation when --force and venv already exists#27
Merged
Conversation
--force now ignores an existing clone AND an existing venv, consistent with the skip-if-present approach used for git clone. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--forcenow skips venv creation (for all types: odoo, python, package) when.venvalready exists, consistent with how it skips git clone when the repo already exists_venv_existshelper andforceparameter tosetup_odoo_venvTest plan
configure <instance> --forceon an instance with an existing clone and venv — should skip both clone and venv creation with yellow warningsconfigure <instance>(no--force) on a fresh instance — venv is created as beforeconfigure <instance>(no--force) when instance already exists — should still error out🤖 Generated with Claude Code