Repository navigation
fix: the last native date fields use the app's own picker - #429
Merged
Merged
Conversation
The audit log's From/To filter (a native mm/dd/yyyy field), the scan replay dialog and an event's sunset date now use DatePicker / DateTimePicker, as every other date in the app does. Optional fields get a Clear button; the audit log's To calendar disables the days before From, so a backwards range cannot be picked. The picker button carries its wire value as data-value for tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three fields still showed the browser's native date input, with its own mm/dd/yyyy format and theme. All three now use the app's picker.
DatePicker.DateTimePicker. Required fields and errors are still announced througharia-requiredandaria-invalid.DateTimePickerwith Clear.Picker changes:
clearable,aria-invalidandaria-required.data-value, so tests read the exact value.test/pickers.ts(pickDate) drives the picker the way a user does.Follows #428.
Test plan
tsc -band oxlint pass.the audit log filters by day with the in-app calendarpasses locally.🤖 Generated with Claude Code