Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .server-changes/reduce-api-tracing-overhead.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
area: webapp
type: improvement
---

Reduced internal overhead on the API under high load.
36 changes: 34 additions & 2 deletions apps/webapp/app/v3/tracer.server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,15 @@ import {
trace,
metrics,
type Meter,
type TextMapPropagator,
type TextMapGetter,
type TextMapSetter,
} from "@opentelemetry/api";
import {
CompositePropagator,
W3CBaggagePropagator,
W3CTraceContextPropagator,
} from "@opentelemetry/core";
import sentryRemix from "@sentry/remix";
import { logs, SeverityNumber } from "@opentelemetry/api-logs";
import { OTLPTraceExporter } from "@opentelemetry/exporter-trace-otlp-http";
Expand Down Expand Up @@ -125,6 +133,24 @@ class CustomWebappSampler implements Sampler {
}
}

class NonInheritingTraceContextPropagator implements TextMapPropagator {
private readonly _delegate = new CompositePropagator({
propagators: [new W3CTraceContextPropagator(), new W3CBaggagePropagator()],
});

inject(context: Context, carrier: unknown, setter: TextMapSetter): void {
this._delegate.inject(context, carrier, setter);
}

extract(context: Context, carrier: unknown, getter: TextMapGetter): Context {
return trace.deleteSpan(this._delegate.extract(context, carrier, getter));
}

fields(): string[] {
return this._delegate.fields();
}
}
Comment thread
ericallam marked this conversation as resolved.

export const {
tracer,
logger: otelLogger,
Expand Down Expand Up @@ -281,11 +307,14 @@ function setupTelemetry() {
}
}

const ratioSampler = new TraceIdRatioBasedSampler(samplingRate);

const provider = new NodeTracerProvider({
forceFlushTimeoutMillis: 15_000,
resource: getResource(),
sampler: new ParentBasedSampler({
root: new CustomWebappSampler(new TraceIdRatioBasedSampler(samplingRate)),
root: new CustomWebappSampler(ratioSampler),
remoteParentSampled: ratioSampler,
}),
spanLimits: {
attributeCountLimit: 1024,
Expand Down Expand Up @@ -324,7 +353,10 @@ function setupTelemetry() {
);
}

provider.register({ contextManager: createContextManager() });
provider.register({
contextManager: createContextManager(),
propagator: new NonInheritingTraceContextPropagator(),
});
Comment thread
ericallam marked this conversation as resolved.

let instrumentations: Instrumentation[] = [
new AwsSdkInstrumentation({
Expand Down
Loading