Skip to content

Pr 3319 fix #3321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepshekhardas wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

Pr 3319 fix #3321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/animated-resizable-panel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"@trigger.dev/core": patch
"@trigger.dev/sdk": patch
Comment on lines +2 to +3

@coderabbitai coderabbitai Bot Jun 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Changeset bumps appear to target unrelated packages.

This PR’s code changes are in apps/webapp, but the changeset bumps @trigger.dev/core and @trigger.dev/sdk. That will trigger unnecessary package releases/changelog entries. Please retarget the changeset to the actually affected publishable package(s), or remove the changeset if this is webapp-only.

---

Feat(webapp): animated resizable panel

Adds animated open/close transitions to Resizable panels using react-window-splitter built-in animation hooks. Includes new exports: RESIZABLE_PANEL_ANIMATION, collapsibleHandleClassName(), and useFrozenValue(). Converts inspector/detail side panels from conditionally-mounted to always-mounted collapsible panels across multiple routes (batches, runs, schedules, deployments, logs, waitpoints, bulk-actions).
Comment on lines +1 to +8

@devin-ai-integration devin-ai-integration Bot Jun 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 Changeset targets @trigger.dev/core and @trigger.dev/sdk but PR only modifies webapp files

The changeset at .changeset/animated-resizable-panel.md declares @trigger.dev/core: patch and @trigger.dev/sdk: patch, but none of the PR's changes touch files in packages/core or packages/trigger-sdk. The exports mentioned in the changeset description (RESIZABLE_PANEL_ANIMATION, collapsibleHandleClassName(), useFrozenValue()) only exist in the webapp's Resizable.tsx component, not in either published package. This will cause unnecessary version bumps and changelog entries for packages that weren't actually changed.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines +1 to +8

@devin-ai-integration devin-ai-integration Bot Aug 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Release note file bumps two published packages even though only the dashboard changed

A package release note is added (.changeset/animated-resizable-panel.md:1-8) marking two published packages for a version bump, although the change only touches dashboard code, so unnecessary package releases are published with a note describing internal tooling.
Impact: Users see a needless new release of two packages whose code did not change, with release notes describing internal implementation details.

Repo rules require a .server-changes entry for webapp-only changes

AGENTS.md and CONTRIBUTING.md state: "When modifying only server components (apps/webapp/, ...) with no package changes, add a .server-changes/ file instead" of a changeset. This PR only modifies apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.logs/route.tsx, yet the changeset declares "@trigger.dev/core": patch and "@trigger.dev/sdk": patch.

Additionally, the rules require the note be "written for users, not maintainers" and to "never name internal tools or infra"; the body names react-window-splitter and exported symbols (RESIZABLE_PANEL_ANIMATION, collapsibleHandleClassName(), useFrozenValue()).

Prompt for agents 
This PR only modifies apps/webapp, so per AGENTS.md/CONTRIBUTING.md it should use a .server-changes/ markdown file (frontmatter: area: webapp, type: improvement) with a one-line user-facing description, instead of a changeset that bumps @trigger.dev/core and @trigger.dev/sdk. Also rewrite the description so it does not name internal libraries or exported symbols.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

2 changes: 1 addition & 1 deletion ...pp/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.logs/route.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ function LogsList({
const frozenLogId = useFrozenValue(selectedLogId);
const frozenLog = useFrozenValue(selectedLog);
const displayLogId = selectedLogId ?? frozenLogId;
const displayLog = selectedLog ?? frozenLog ?? undefined;
const displayLog = selectedLog ?? frozenLog;

const updateUrlWithLog = useCallback((logId: string | undefined) => {
const url = new URL(window.location.href);
Expand Down