fix: hide Recents heading when every recent thread is starred - #192
Merged
Merged
Conversation
The condition compared threads.length against the starred–recent intersection, which could be true even when groups (the non-starred content) was empty — e.g. when the only recent thread was starred. Check groups directly instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sidebar showed an empty "Recents" heading when the only recent thread was starred. The old condition compared
threads.lengthagainst the starred–recent intersection count, which could be true even when the non-starred groups were empty.\n\nReplaced with a direct check ongroups— if no group has items, "Recents" stays hidden.\n\nIncludes a test covering the starred-only scenario.