feat(app): add confirmation dialog before submitting payments - #313
Open
binayyub4211 wants to merge 1 commit into
Open
feat(app): add confirmation dialog before submitting payments#313binayyub4211 wants to merge 1 commit into
binayyub4211 wants to merge 1 commit into
Conversation
Spagero763
enabled auto-merge (squash)
July 20, 2026 13:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Title
feat(app): add confirmation dialog before submitting payments
PR Description
What was done
Implemented a payment confirmation modal dialog overlay in PaySplit.tsx component.
Updated styling in styles.css to add modal overlay layout and design utilities.
Added localized translations for both English and Vietnamese languages in i18n.tsx.
Configured Vitest to run in jsdom testing environment in vite.config.ts.
Created a robust unit test suite in PaySplit.test.tsx verifying:
Select inputs validation.
Showing the confirmation modal listing the per-recipient breakdown details (addresses and exact payout amounts).
Dialog cancellation behavior.
Signature submission triggers.
Why it was done
To prevent users from signing a split payment transaction without reviewing the individual breakdown first, improving transparency and validation before signing.
How it was verified
Verified Vitest test suite runs and passes successfully:
bash
✓ src/lib/tributary.test.ts (13 tests) 41ms
✓ src/components/PaySplit.test.tsx (4 tests) 1520ms
Test Files 2 passed (2)
Tests 17 passed (17)
Verified the client app builds successfully for production (npm run build).
Closes #150