test: assert BadShareTotal error on update_split - #278
Open
dominiccreates wants to merge 5 commits into
Open
Conversation
Contributor
|
@dominiccreates kindly resolve conflicts |
Spagero763
enabled auto-merge (squash)
July 20, 2026 13:47
auto-merge was automatically disabled
July 20, 2026 13:57
Head branch was pushed to by a user without write access
Spagero763
enabled auto-merge (squash)
July 20, 2026 14:18
auto-merge was automatically disabled
July 22, 2026 07:30
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #98 Adds a unit test to verify that the update_split method rejects share distributions that do not sum to exactly 10,000 basis points with a BadShareTotal typed error.
Changes
test.rs
: Added update_split_rejects_shares_not_summing_to_10_000 unit test to assert that try_update_split returns Err(Ok(Error::BadShareTotal)) when updated shares do not sum to TOTAL_SHARES (10,000).
Verification
Ran local test runner verifying all 24 tests pass successfully.
Verified cargo code formatting and clippy lints pass cleanly.
Verified client application and SDK build successfully.