Repository navigation
[BUGFIX] GUI: HDD mode checkbox reads its default from verbose - #301
Merged
Merged
Conversation
… verbose The "Use mapwriter HDD mode" checkbox got its default value from oInputData.verbose. Both default to False, so the wrong default is not visible today, but the checkbox would follow the verbose setting instead of the hdd_mode setting. Also fixes the indentation of the continuation line. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR…
Fixes the default value of the "Use mapwriter HDD mode" checkbox in the GUI (Advanced settings tab).
Considerations and implementations
CheckbuttonsTab2builds the checkbox withoInputData.verboseas its default:It should be
oInputData.hdd_mode. Both attributes default toFalse, so the wrong pre-selection is not visible today — the checkbox simply mirrors the verbose default. It becomes wrong as soon as either default changes orInputDatais pre-filled from somewhere other than the constructor.The value written back on "Create map" already reads the right variable (
GuiInput.read_input_from_gui→self.o_input_data.hdd_mode = tab2.first.checkb_mapwriter_ram_hdd_val.get()), so only the default was affected.Also corrects the indentation of the continuation line, which pylint flags.
How to test
self.hdd_mode = TrueinInputData.__init__and restart the GUI — the checkbox is now pre-selected. Before this change it stayed unchecked.Pull Request Checklist
🤖 Generated with Claude Code