Conversation
milahu
force-pushed
the
rename-attribute_value-to-unquoted_attribute_value-etc
branch
from
March 5, 2024 16:48
691d4dd to
737162e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this makes my life easier when using this parser in an AST transformer
the problem is that currently, attribute_value has 2 meanings:
i want to process only the parent nodes attribute_value and quoted_attribute_value
and ignore the child nodes: singlequote, doublequote, attribute_value
but currently, both parent and child nodes have the same node.kind_id
i propose to change this to
similar to #89
maybe
group the three attribute value types under one attribute_value
fixme
noval= boolis parsed as one attributewhen it should be parsed as two attributes
fix: disallow whitespace between nodes