Skip to content

chore(deps): allège le noyau (fastapi nu + uvicorn, xcdk/xcorecli en extras) - #307

Merged
traoreera merged 1 commit into
mainfrom
chore/trim-runtime-deps
Oct 15, 2026
Merged

traoreera merged 1 commit into
mainfrom
chore/trim-runtime-deps

Conversation

@traoreera

@traoreera traoreera commented Oct 15, 2026 •

Copy link
Copy Markdown
Owner

Objectif

Réduire le socle de dépendances installé inconditionnellement par pip install XCoreRuntime, qui était passé à ~59 paquets (dont beaucoup inutiles) après l'introduction de xcdk/xcorecli dans le noyau en 2.8.0.

Changements

  • fastapi[standard] → fastapi + uvicorn[standard] : retire tout le cluster fastapi-cli/fastapi-cloud-cli (sentry-sdk, typer, rich-toolkit, rignore, fastar, agent-detector, detect-installer) ainsi que jinja2, python-multipart, email-validator, pydantic-settings, pydantic-extra-types, dnspython — aucun n'est importé par xcore.
  • xcdk (extra [sdk]) et xcorecli (extra [xcli]) repassent en optionnels : promus au noyau par erreur en 2.8.0. Aucun des deux n'est importé par xcore (xcdk n'est résolu que dans un try/except de xcore/sdk/__init__.py). Conservés en dev pour poetry run xcli et le chemin CI.
  • opentelemetry-api retiré : tiré transitivement par opentelemetry-sdk (épinglé ==1.45.1).

Le noyau se limite désormais à 6 paquets : fastapi, uvicorn[standard], pydantic, pyyaml, apscheduler, opentelemetry-sdk.

Vérifications

  • poetry.lock : 146 → 133 paquets.
  • import xcore et le boot zero-config fonctionnent sans aucun paquet optionnel — tests/unit/test_optional_dependencies.py bloque désormais aussi sdk/xcli.
  • Suite complète : 1499 passed, 15 skipped, couverture ≥ 80 % (gate OK).
  • make lint-check OK.

Doc

Entrée ajoutée dans [Unreleased] de doc/changelog.md.

Summary by Sourcery

Reduce the default XCoreRuntime installation footprint while preserving optional CLI and plugin-SDK functionality.

Bug Fixes:

  • Restore xcdk and xcorecli as optional extras so installing the runtime no longer pulls in the plugin SDK and CLI by default.

Enhancements:

  • Reduce the unconditional runtime dependency set to six packages by replacing fastapi[standard] with fastapi and explicit uvicorn[standard], and removing redundant dependencies.
  • Keep xcdk and xcorecli available in the development environment while preserving optional-dependency support and zero-config operation.

Build:

  • Regenerate poetry.lock, reducing the locked package set from 146 to 133 packages.

Documentation:

  • Document the leaner core installation and restored optional dependencies in the Unreleased changelog.

Tests:

  • Extend optional-dependency coverage to verify that xcore imports and boots without the SDK and CLI packages.

… extras

Le socle inconditionnel de `pip install XCoreRuntime` passe de ~59 paquets à 6 :
- fastapi[standard] -> fastapi + uvicorn[standard] (retire fastapi-cli /
  fastapi-cloud-cli — donc sentry-sdk, typer, rich-toolkit, rignore, fastar,
  agent-detector, detect-installer — ainsi que jinja2, python-multipart,
  email-validator, pydantic-settings, pydantic-extra-types, dnspython)
- xcdk et xcorecli repassent en extras [sdk]/[xcli] (promus au noyau par
  erreur en 2.8.0) ; conservés en dev pour `poetry run xcli` et le chemin CI
- suppression d'opentelemetry-api (tiré transitivement par opentelemetry-sdk)

poetry.lock : 146 -> 133 paquets. test_optional_dependencies.py bloque aussi
sdk/xcli et verrouille le boot zero-config sans aucun paquet optionnel.
@sourcery-ai

sourcery-ai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Le PR allège l’installation de base à six dépendances en séparant le framework FastAPI de ses extras, en rendant xcdk et xcorecli optionnels et en supprimant une dépendance OpenTelemetry redondante. Le lockfile, les tests d’installation minimale et le changelog sont mis à jour pour garantir et documenter que xcore reste importable et fonctionnel sans aucun extra.

Sequence diagram for minimal XCoreRuntime boot without optional extras

sequenceDiagram
    participant User
    participant Python
    participant xcore
    participant CoreDeps
    participant OptionalDeps

    User->>Python: import xcore
    Python->>xcore: load core modules
    xcore->>CoreDeps: import fastapi, pydantic, pyyaml
    xcore->>CoreDeps: import apscheduler, opentelemetry-sdk
    xcore-->>Python: import succeeds
    User->>xcore: start zero-config boot
    xcore-->>User: boot succeeds
    Note over OptionalDeps: No xcdk or xcorecli required
Loading

File-Level Changes

Change Details Files
Réduction des dépendances installées dans le noyau tout en conservant les composants nécessaires au serveur et au démarrage zero-config.
  • Remplacer fastapi[standard] par fastapi et ajouter explicitement uvicorn[standard].
  • Supprimer la dépendance directe à opentelemetry-api, désormais fournie transitivement par le SDK.
  • Régénérer le lockfile, qui passe de 146 à 133 paquets.
pyproject.toml
poetry.lock
Rendre le CLI et le SDK d’auteur de plugins optionnels au runtime.
  • Retirer xcorecli et xcdk des dépendances de production.
  • Les conserver dans le groupe de développement pour les commandes locales et les chemins CI.
  • Maintenir leur exposition via les extras [xcli] et [sdk].
pyproject.toml
Renforcer la vérification de l’installation minimale et documenter le changement.
  • Bloquer aussi les modules sdk/xcli et leurs paquets dans le test d’absence des dépendances optionnelles.
  • Vérifier que import xcore et le boot zero-config fonctionnent sans extras.
  • Ajouter la description de la nouvelle composition du noyau dans le changelog.
tests/unit/test_optional_dependencies.py
doc/changelog.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@github-actions github-actions Bot added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file tests config labels Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@traoreera
traoreera merged commit 7c95dff into main Oct 15, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant