Repository navigation
Handle missing Kafka Connect task configuration explicitly - #11
Closed
olalekan-code wants to merge 1 commit into
Closed
olalekan-code wants to merge 1 commit into
olalekan-code wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
During a production MirrorMaker rebalance, a newly started worker was assigned task 1 after replaying the config topic. Its local
ClusterConfigStatecontained the connector config but no task config for the assigned task.DistributedHerderpassed the null map toWorker, which eventually failed with the opaque exception:NullPointerException: Cannot invoke java.util.Map.size() because inputMap is nullThe signature matches the failure family tracked in Apache KAFKA-10323 and KAFKA-13486.
Change
ConnectExceptionScope
This is a diagnostic and safety guard. It prevents the misleading
TaskConfig(null)NPE and exposes the backing-store inconsistency directly. It does not automatically repair an incomplete compacted task-config generation. Correct automatic repair requires leader-side task reconfiguration/inter-worker coordination;DistributedHerderTest.testInconsistentConfigsalready records that larger FIXME.Validation
DistributedHerderTestclass passedcheckstyleMain,checkstyleTest, andspotbugsMainpassed as dependencies of the Gradle test taskgit diff --checkpassedProduction image construction uses the Kafka 4.0.1 fork line, and the deployed fork commit contains
origin/4.0in its ancestry. A separatetw-kafka-connectpin should only follow after this change is reviewed and released.