[iamralch]

Does your PR solve an issue?

fixes #4426

This is option 1 from the discussion there: socket-only, Postgres only. A caller-supplied TLS upgrade, which a MySQL connect_with_socket would need, is left for a follow-up if this direction is accepted.

Two commits, each usable on its own. Happy to split them into separate PRs if that's easier to review.

1. fix(core): use a wasm-safe Instant on wasm32-unknown-unknown. QueryLogger::new calls std::time::Instant::now() for every query, and that panics on wasm32-unknown-unknown with time not implemented on this platform. This adds sqlx_core::rt::Instant, which is std::time::Instant everywhere else and web_time::Instant (the host's performance.now()) on that target. It's used in the query logger and the Postgres, MySQL and SQLite migrators. web-time is a dependency on that target only.
2. feat(postgres): add PgConnection::connect_with_socket. This takes any sqlx_core::net::Socket the caller has already connected. The host, port and socket path in the options are ignored. Everything else, including ssl_mode, applies as it does for connect_with. establish now goes through the same path after opening its own socket, so existing connections are unchanged.

The motivating host is Cloudflare Workers, which hands out its own TCP sockets (e.g. to reach Postgres through Hyperdrive) and has no tokio. TLS doesn't need a hook for Postgres: a caller whose host upgrades the socket itself can send the SSLRequest, upgrade, and pass the result in with ssl_mode = Disable.

Tests

• New it_connects_with_socket in tests/postgres/postgres.rs: a tokio TcpStream opened by the test, then connect_with_socket.
• Existing tests/postgres/postgres.rs (58 passed, 2 ignored) and tests/postgres/migrate.rs (4 passed).
• On wasm32-unknown-unknown, a Worker under wrangler dev --local against Postgres 17 with SCRAM auth: connect, bound parameters and scalar types, 2,000 rows over many socket reads, unique-violation mapping, rollback and commit, prepared-statement reuse, sqlx::migrate!(), ping and close. Reverting only the Instant commit makes the same Worker panic.

A downstream crate built on this branch, with those scenarios in CI: sqlx-contrib/sqlx-cloudflare#16 (sqlx-cloudflare-hd).

Is this a breaking change?

No. Both changes only add public items (PgConnection::connect_with_socket, sqlx_core::rt::Instant). sqlx_core::rt::Instant is std::time::Instant on every target except wasm32-unknown-unknown, where Instant::now() panicked before. Existing connect_with behaviour is unchanged; it now delegates to the same code path after opening its socket.

[abonander]

I don't want to support wasm32-unknown-unknown. It is too ridiculous of a target to try to support, and I don't want anything in our manifests or CI contig that implies that it's supported. I'm continuously frustrated by the fact that WASM problems become my problems even when I never asked for them to be.

I recommend trying CloudFlare's experimental support for WASI, which might work without other code changes. As for accepting external sockets, there's already several other open PRs that I have to review.