trailofbits · pgoodman · Apr 15, 2026 · Apr 15, 2026 · Apr 15, 2026 · Apr 15, 2026
diff --git a/bin/Index/IdStore.cpp b/bin/Index/IdStore.cpp
@@ -241,8 +241,8 @@ struct IdConfig {
 
 class IdStoreImpl {
  public:
-  const std::unique_ptr<rocksdb::DB> rocks_db;
-  rocksdb::ColumnFamilyHandle * const cf_handle;
+  std::unique_ptr<rocksdb::DB> rocks_db;
+  rocksdb::ColumnFamilyHandle *cf_handle;
 
   std::deque<IdConfig> configs;
 
@@ -289,8 +289,8 @@ class IdStoreImpl {
     ExitRocksDB();
   }
 
-  IdStoreImpl(rocksdb::DB *rocks_db_)
-      : rocks_db(rocks_db_),
+  IdStoreImpl(std::unique_ptr<rocksdb::DB> rocks_db_)
+      : rocks_db(std::move(rocks_db_)),
         cf_handle(rocks_db->DefaultColumnFamily()),
         next_file_index(configs.emplace_back(
             "META:NEXT_FILE_INDEX", "FID", 1u, mx::kMaxFileId)),
@@ -404,14 +404,14 @@ std::shared_ptr<IdStoreImpl> IdStoreImpl::Open(std::filesystem::path path) {
     return already_open_db;
   }
 
-  rocksdb::DB *rocks_db_ptr = nullptr;
+  std::unique_ptr<rocksdb::DB> rocks_db_ptr;
   auto status = rocksdb::DB::Open(DBOptions(), name, &rocks_db_ptr);
 
   CHECK(status.ok())
       << "Unable to open RocksDB database at " << abs_kvdir << ": "
       << status.ToString();
 
-  auto db_ptr = std::make_shared<IdStoreImpl>(rocks_db_ptr);
+  auto db_ptr = std::make_shared<IdStoreImpl>(std::move(rocks_db_ptr));
   db_ptr_ref = db_ptr;
   return db_ptr;
 }

diff --git a/bin/Index/Main.cpp b/bin/Index/Main.cpp
@@ -7,6 +7,7 @@
 #include <cstdlib>
 #include <cstring>
 #include <fcntl.h>
+#include <unistd.h>
 #include <filesystem>
 #include <gflags/gflags.h>
 #include <glog/logging.h>

diff --git a/vendor/abseil/src b/vendor/abseil/src
diff --git a/vendor/capnproto/src b/vendor/capnproto/src
diff --git a/vendor/concurrentqueue/src b/vendor/concurrentqueue/src
diff --git a/vendor/gflags/src b/vendor/gflags/src
diff --git a/vendor/glog/src b/vendor/glog/src
diff --git a/vendor/re2/src b/vendor/re2/src
diff --git a/vendor/reproc/src b/vendor/reproc/src
diff --git a/vendor/rocksdb/CMakeLists.txt b/vendor/rocksdb/CMakeLists.txt
@@ -75,6 +75,7 @@ execute_process(COMMAND ${CMAKE_COMMAND}
                         -DFAIL_ON_WARNINGS:BOOL=OFF
                         -DWITH_DYNAMIC_EXTENSION:BOOL=OFF
                         -DROCKSDB_BUILD_SHARED:BOOL=OFF
+                        -DPORTABLE:BOOL=ON
                         -DBUILD_TESTING:BOOL=OFF
                         -DUSE_RTTI:BOOL=ON
                         "${src_dir}"

diff --git a/vendor/rocksdb/src b/vendor/rocksdb/src
diff --git a/vendor/zstd/src b/vendor/zstd/src
+40 −15		.github/workflows/quick-test.yml
+41 −42		.github/workflows/release-test.yml
+1 −0		.gitignore
+1 −1		CMakeLists.txt
+39 −36		c++/CMakeLists.txt
+11 −0		c++/MODULE.bazel
+1 −1		c++/Makefile.am
+3 −3		c++/WORKSPACE
+0 −3		c++/compile_flags.txt
+34 −1		c++/configure.ac
+1 −1		c++/samples/CMakeLists.txt
+5 −0		c++/src/capnp/BUILD.bazel
+1 −1		c++/src/capnp/c++.capnp.h
+1 −1		c++/src/capnp/common.h
+1 −0		c++/src/capnp/compat/BUILD.bazel
+1 −1		c++/src/capnp/compat/json.capnp.h
+20 −0		c++/src/capnp/compiler/capnp.c++
+1 −1		c++/src/capnp/compiler/capnpc-c++.c++
+3 −0		c++/src/capnp/compiler/compiler.h
+21 −0		c++/src/capnp/compiler/error-reporter.h
+30 −2		c++/src/capnp/compiler/generics.c++
+11 −0		c++/src/capnp/compiler/generics.h
+1 −1		c++/src/capnp/compiler/grammar.capnp.h
+1 −1		c++/src/capnp/compiler/lexer.capnp.h
+9 −0		c++/src/capnp/compiler/module-loader.c++
+12 −0		c++/src/capnp/compiler/node-translator.c++
+19 −0		c++/src/capnp/dynamic-test.c++
+2 −0		c++/src/capnp/dynamic.c++
+1 −1		c++/src/capnp/persistent.capnp.h
+48 −0		c++/src/capnp/rpc-test.c++
+33 −27		c++/src/capnp/rpc-twoparty-test.c++
+1 −1		c++/src/capnp/rpc-twoparty.capnp.h
+3 −2		c++/src/capnp/rpc.c++
+1 −1		c++/src/capnp/rpc.capnp.h
+28 −3		c++/src/capnp/schema.capnp
+655 −373		c++/src/capnp/schema.capnp.c++
+680 −10		c++/src/capnp/schema.capnp.h
+17 −0		c++/src/capnp/serialize-async-test.c++
+4 −6		c++/src/capnp/serialize-async.c++
+14 −0		c++/src/capnp/serialize-test.c++
+18 −3		c++/src/capnp/serialize.c++
+1 −1		c++/src/capnp/stream.capnp.h
+1 −0		c++/src/capnp/test-util.h
+3 −2		c++/src/capnp/test.capnp
+10 −0		c++/src/capnp/testdata/errors.capnp.nobuild
+1 −0		c++/src/capnp/testdata/errors.txt
+2 −2		c++/src/kj/BUILD.bazel
+17 −4		c++/src/kj/CMakeLists.txt
+3 −1		c++/src/kj/async-inl.h
+4 −0		c++/src/kj/async-io-test.c++
+25 −32		c++/src/kj/async-io-unix.c++
+20 −20		c++/src/kj/async-io-win32.c++
+10 −0		c++/src/kj/async-io.h
+3 −2		c++/src/kj/async-unix.h
+37 −0		c++/src/kj/async-xthread-test.c++
+1 −0		c++/src/kj/async.c++
+1 −0		c++/src/kj/cidr.c++
+3 −0		c++/src/kj/common-test.c++
+8 −5		c++/src/kj/common.h
+60 −0		c++/src/kj/compat/http-test.c++
+43 −11		c++/src/kj/compat/http.c++
+8 −2		c++/src/kj/exception.c++
+12 −0		c++/src/kj/filesystem-disk-test.c++
+19 −3		c++/src/kj/filesystem-disk-unix.c++
+3 −0		c++/src/kj/filesystem-disk-win32.c++
+55 −3		c++/src/kj/io.c++
+49 −1		c++/src/kj/string-test.c++
+1 −1		c++/src/kj/string.h
+5 −9		c++/src/kj/timer.c++
+8 −8		doc/install.md
+3 −0		doc/otherlang.md
+13 −4		release.sh
+45 −0		security-advisories/2026-03-12-0-segment-count-overflow.md
+59 −0		security-advisories/2026-03-12-1-http-size-validation.md
+31 −14		super-test.sh
+2 −1		CMakeLists.txt
+1 −1		README.md
+1 −1		benchmarks/extract_graph_data.py
+29 −19		blockingconcurrentqueue.h
+30 −8		concurrentqueue.h
+18 −6		lightweightsemaphore.h
+75 −0		tests/unittests/unittests.cpp
+51 −0		.github/workflows/test.yml
+1 −0		.gitignore
+0 −20		.travis.yml
+12 −0		.vscode/settings.json
+33 −21		CMakeLists.txt
+37 −22		ChangeLog.txt
+11 −8		INSTALL.md
+6 −0		MODULE.bazel
+204 −0		MODULE.bazel.lock
+14 −3		README.md
+0 −68		appveyor.yml
+7 −6		bazel/gflags.bzl
+6 −7		cmake/utils.cmake
+32 −16		cmake/version.cmake.in
+584 −540		doc/index.html
+10 −8		src/gflags.cc
+5 −5		src/gflags_completions.cc
+2 −2		src/gflags_completions.h.in
+24 −2		test/CMakeLists.txt
+5 −0		test/cmake/CMakeLists.txt
+94 −0		test/cmake/package_version.cmake
+48 −0		test/cmake/version_numbers.cmake
+1 −1		test/config/CMakeLists.txt
+2 −0		test/gflags_declare_flags.cc
+1 −1		test/nc/CMakeLists.txt
+2 −2		.bazelci/presubmit.yml
+2 −2		.clang-format
+2 −2		.github/workflows/android.yml
+1 −1		.github/workflows/cifuzz.yml
+3 −10		.github/workflows/emscripten.yml
+4 −11		.github/workflows/linux.yml
+2 −8		.github/workflows/macos.yml
+8 −15		.github/workflows/windows.yml
+360 −260		CMakeLists.txt
+1 −38		COPYING
+10 −0		ChangeLog
+6 −0		MODULE.bazel
+310 −189		README.rst
+42 −80		bazel/glog.bzl
+12 −8		cmake/RunCleanerTest1.cmake
+12 −8		cmake/RunCleanerTest2.cmake
+12 −8		cmake/RunCleanerTest3.cmake
+7 −0		codecov.yml
+1 −0		gcovr.cfg
+2 −0		glog-config.cmake.in
+45 −47		src/base/commandlineflags.h
+9 −11		src/base/googleinit.h
+0 −333		src/base/mutex.h
+11 −10		src/cleanup_immediately_unittest.cc
+11 −10		src/cleanup_with_absolute_prefix_unittest.cc
+11 −10		src/cleanup_with_relative_prefix_unittest.cc
+30 −68		src/config.h.cmake.in
+7 −0		src/dcheck_unittest/CMakeLists.txt
+53 −0		src/dcheck_unittest/glog_dcheck.cc
+212 −223		src/demangle.cc
+17 −8		src/demangle.h
+18 −21		src/demangle_unittest.cc
+7 −0		src/demangle_unittest.txt
+158 −0		src/flags.cc
+1 −1		src/fuzz_demangle.cc
+191 −0		src/glog/flags.h
+42 −14		src/glog/log_severity.h
+682 −783		src/glog/logging.h
+13 −12		src/glog/platform.h
+74 −76		src/glog/raw_logging.h
+55 −64		src/glog/stl_logging.h
+81 −0		src/glog/types.h
+34 −20		src/glog/vlog_is_on.h
+191 −240		src/googletest.h
+16 −0		src/includes_unittest/CMakeLists.txt
+39 −0		src/includes_unittest/glog_includes_logging.cc
+39 −0		src/includes_unittest/glog_includes_raw_logging.cc
+4 −5		src/includes_unittest/glog_includes_stl_logging.cc
+4 −5		src/includes_unittest/glog_includes_vlog_is_on.cc
+10 −0		src/log_severity_unittest/CMakeLists.txt
+40 −0		src/log_severity_unittest/glog_log_severity_constants.cc
+42 −0		src/log_severity_unittest/glog_log_severity_conversion.cc
+937 −863		src/logging.cc
+11 −10		src/logging_striplog_test.sh
+343 −273		src/logging_unittest.cc
+9 −9		src/mock-log.h
+11 −16		src/mock-log_unittest.cc
+1 −4		src/package_config_unittest/working_config/glog_package_config.cc
+80 −52		src/raw_logging.cc
+86 −96		src/signalhandler.cc
+31 −36		src/signalhandler_unittest.cc
+38 −0		src/stacktrace.cc
+44 −8		src/stacktrace.h
+5 −3		src/stacktrace_generic-inl.h
+8 −6		src/stacktrace_libunwind-inl.h
+18 −15		src/stacktrace_powerpc-inl.h
+61 −56		src/stacktrace_unittest.cc
+21 −21		src/stacktrace_unwind-inl.h
+7 −5		src/stacktrace_windows-inl.h
+22 −21		src/stacktrace_x86-inl.h
+5 −5		src/stl_logging_unittest.cc
+20 −7		src/striplog_unittest.cc
+273 −264		src/symbolize.cc
+102 −48		src/symbolize.h
+123 −105		src/symbolize_unittest.cc
+127 −200		src/utilities.cc
+174 −107		src/utilities.h
+4 −11		src/utilities_unittest.cc
+27 −43		src/vlog_is_on.cc
+623 −728		src/windows/dirent.h
+9 −22		src/windows/port.cc
+56 −95		src/windows/port.h
+4 −4		.bazelrc
+16 −0		.bcr/metadata.template.json
+57 −0		.bcr/presubmit.yml
+5 −0		.bcr/source.template.json
+1 −7		.github/bazel.sh
+5 −5		.github/workflows/ci-bazel.yml
+4 −4		.github/workflows/ci-cmake.yml
+5 −6		.github/workflows/ci.yml
+3 −3		.github/workflows/pages.yml
+0 −34		.github/workflows/pr.yml
+29 −24		.github/workflows/python.yml
+42 −0		.github/workflows/release-bazel.yml
+15 −4		.github/workflows/release.yml
+25 −0		BUILD.bazel
+100 −85		CMakeLists.txt
+0 −1		CONTRIBUTING.md
+10 −10		MODULE.bazel
+1 −1		Makefile
+0 −47		README
+259 −0		README.md
+8 −0		python/BUILD.bazel
+1 −1		python/re2.py
+6 −0		python/re2_test.py
+3 −3		python/setup.py
+3 −4		re2/bitmap256.cc
+15 −10		re2/bitstate.cc
+1 −2		re2/dfa.cc
+3 −4		re2/parse.cc
+1 −2		re2/prog.cc
+1 −0		re2/prog.h
+5 −0		re2/re2.cc
+9 −9		re2/re2.h
+6 −0		re2/set.cc
+5 −0		re2/set.h
+3 −3		re2/testing/re2_arg_test.cc
+8 −0		re2/testing/re2_test.cc
+5 −0		re2/testing/set_test.cc
+1 −1		re2/walker-inl.h
+2 −2		reproc++/src/reproc.cpp
+18 −9		reproc/src/error.posix.c