Conversation
hbrodin
force-pushed
the
fix/427-pull-mirror
branch
from
September 17, 2026 20:03
b6c61b0 to
1b736ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coop pullcould copy a newerpacked-refswhile retaining an older host loose ref, leaving the host on the wrong commit despite a successful transfer. Guest-deleted files also remained on the host.This adds opt-in
coop pull --delete, using rsync--delete-afterso incoming ignore rules apply before deletion. Mirror mode requires working rsync on both ends and refuses to fall back to tar. Plain additive pulls refuse to overlay existing root Git metadata, including with--force; users choose mirroring or--exclude-git. Gitfiles and symlinked root.gitentries require exclusion. A failed local Git status check now blocks an unforced pull.Mirroring can remove host-only files and refs, including committed work in a clean repository.
--forceonly bypasses the dirty check. The docs describe these semantics and rsync's behavior when ignore files are removed.Closes #427.
Validation:
--delete-afterwith--deletecauses the corresponding regression test to fail.src/workspace.rsandsrc/lib.rs: 94 mutations across an interrupted/resumed run: 73 caught, 21 did not compile, zero survivors or timeouts..cargo/mutants.tomlis unchanged.Draft / outstanding gates:
--fullrunner passed bridge isolation and pre-VM phases, then failed at setup because/dev/kvmis unavailable. No macOS/Lima host is available here.cargo deny --workspace checkfails on RUSTSEC-2026-0285 in unchangedrustls 0.23.43; dependency manifests, lockfile, and deny policy are unchanged. Address the dependency advisory separately before merge.