Conversation
hbrodin
marked this pull request as ready for review
September 15, 2026 10:54
hbrodin
force-pushed
the
fix/481-codex-terminal-keyring
branch
from
September 17, 2026 20:03
f166413 to
878c6ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ChatGPT-mode terminal Codex could reuse a desktop app-server whose D-Bus keyring session was unusable, even after the terminal wrapper successfully unlocked its own keyring. The wrapper now prepends
-c 'cli_auth_credentials_store="keyring"', preventing implicit daemon reuse in Codex 0.153.0 and 0.154.0. This also coverscodex-yolo, preserves caller argument precedence and API-key passthrough, and keeps encrypted credential storage.Adds CI tests for wrapper arguments and an opt-in regression using a real app-server on a separate unusable keyring session. The regression verifies that removing the override restores daemon reuse. Documentation explains the version-dependent behavior and how to run the test. Desktop session management remains outside this change.
Fixes #481.
Validation
git diff --check: passed.Remaining gates
Draft pending required validation. Rust build/format/clippy/unit checks were not run because Cargo is unavailable. Lima and Firecracker VM integration suites were not run because neither backend is available here. The local pre-commit hook was bypassed for this commit because
prekis unavailable. CI runs the wrapper tests; the real-daemon regression is opt-in and does not complete either VM gate.