Skip to content

guest: register marketplace for built-in plugins - #475

Open
DarkaMaul wants to merge 3 commits into
mainfrom
dm/fix-marketplace
Open

DarkaMaul wants to merge 3 commits into
mainfrom
dm/fix-marketplace

Conversation

@DarkaMaul

@DarkaMaul DarkaMaul commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • register the official Claude plugin marketplace for the built-in c profile
  • register the same marketplace for the built-in rust profile
  • allow the existing clangd-lsp and rust-analyzer-lsp plugin installs to resolve their marketplace

@DarkaMaul
DarkaMaul marked this pull request as ready for review September 14, 2026 18:40

@hbrodin hbrodin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Alexis, for fixing this! The rest looks good to merge once the requested regression coverage and platform validation pass. Both additions use the exact same official marketplace URL, which looks good.

One coverage request is inline. Review covered correctness, design, conventions, security, CLI usage, tests, docs, and comments; no other diff-introduced issues or diff noise were found. Neither Lima nor Firecracker VM integration was run during this review. Please record results for both platforms, keeping Firecracker's pre-existing omission of profile plugin installation as a separate follow-up. The CI failure tracked in #476 is excluded from this review.

Comment thread src/guest.rs
@hbrodin

hbrodin commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Current CI failure is unrelated and can be disregarded for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants