Repository navigation
fix: serve a moved tag when its archive matches the recorded hash - #86
Merged
traefiker merged 2 commits intoOct 29, 2026
Merged
Conversation
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
darkweaver87
approved these changes
Oct 28, 2026
darkweaver87
left a comment
darkweaver87
left a comment
Contributor
There was a problem hiding this comment.
LGTM, see my comments through
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #83, a moved tag is served from the commit the Go module proxy pinned at publication. For versions whose hash was recorded before that, the recorded hash is the one of the moved tag, which is what users load today. Serving the pinned commit breaks them: the bytes no longer match the hash, and for some versions the pinned code does not build with Yaegi, the tag was moved to fix that.
Now, when the tag moved and a hash is recorded, the tag archive is hashed. If it matches the recorded hash, the tag is served, otherwise the pinned commit. Only bytes that match a recorded hash are served, so a tag moved today still gets the pinned commit. New versions are not affected: their hash is recorded from the pinned commit.
The tag archive hash is cached by tag commit, so it costs one download per moved tag.