Repository navigation
fix: serve the moved tag when the pinned commit is gone and a hash is recorded - #85
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a tag moved after publication and GitHub no longer has the commit the Go module proxy pinned (history rewritten), the archive cannot be downloaded and the download fails with a 500.
In that case, the moved tag is now served, but only if a hash is already recorded for the version, so the plugin keeps working as before #83. Without a recorded hash, the version is not served, so a hash is never recorded from code the proxy did not pin.
Motivation
Two public versions are in this case today:
agence-gaya/traefik-plugin-cloudflarev1.0.0 andmadebymode/traefik-modsecurity-pluginv1.0.0.More