Repository navigation
fix: evaluate the commit pinned by the Go module proxy in private mode - #164
Merged
Merged
Conversation
darkweaver87
approved these changes
Oct 28, 2026
The pinned commit is now found once, by the scrapper, with retries. A private repository is never sent to the Go module proxy, and a proxy failure has its own error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In private mode, piceus reads the plugin at the tag. plugin-service serves the commit the Go module proxy pinned at publication (traefik/plugin-service#83), so once a tag moved, piceus evaluates code that users never get.
piceus now reads the plugin (code,
.traefik.yml, readme andgo.mod) at the pinned commit, and at the tag only when the proxy pinned none, as plugin-service does. A version whose pinned code does not build is reported to its author like any other evaluation error.Private repositories are not sent to the proxy. If the proxy still cannot be read after 3 attempts, the plugin is skipped for this run and no issue is opened.